EMSUSD-1612 allow duplicating material to USD #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
commented
Sep 12, 2024
| @@ -580,14 +580,19 @@ PushExportResult pushExport(const MObject& mayaObject, const UsdMayaPrimUpdaterC | |||
|
|
|||
There was a problem hiding this comment.
For the diff in this file, turn off whitespace changes, because a lot of lines only changed indentation.
barbalt
previously approved these changes
Sep 12, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
workflows
Refactor the prim update manager: - Refactor the duplicate function into two functions: duplicateToMaya and duplicateToUsd. - The duplicateToUsd function takes a Maya node instead of a UFE path to support Maya materials, which are not DAG objects. - Support non-DAG object in the pushExport function when creating the full object list. - This is necessary so that the material-only export correctly identify the material as being in the selection. Improve the duplicate command: - Support parsing pure Maya object names as the first argument to the duplicate command. - When the first argument cannot be parsed as UFE then directly call the USD duplicate function with the Maya object instead of the UFE path. Add a unit test for duplicating to USD a material.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1612/dup-material-menu
branch
from
8db3de1
to
0e7fbda
Compare
|
I only fixed the merge conflicts, nothing else changed. |
barbalt
approved these changes
Sep 18, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the prim update manager:
Improve the duplicate command:
Add a unit test for duplicating to USD a material.